keep matching exception to found errorpage #9090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
added
the
TCK
olamy
force-pushed
the
jetty-12.0.x-exception-unwrap-matching-errorpage
branch
2 times, most recently
from
55ca383
to
d8ba0d9
Compare
gregw
approved these changes
Jan 26, 2023
| * @return the first non {@link ServletException} from root cause chain | ||
| */ | ||
| private Throwable getFirstNonServletException(Throwable t) | ||
| private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable) |
There was a problem hiding this comment.
This name is not correct now. How about:
Suggested change
| private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable) | |
| private Throwable unwrapServletException(Throwable t, Class<?> matchedThrowable) |
Suggested change
| private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable) | |
| private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable) |
There was a problem hiding this comment.
good idea!
done in 3643858
…rror page found Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
force-pushed
the
jetty-12.0.x-exception-unwrap-matching-errorpage
branch
from
d8ba0d9
to
3643858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix TCK test
com.sun.ts.tests.servlet.spec.errorpage1.URLClient#servletExceptionTest