Issue #6642 - WebSocket handling of Connection: upgrade,close. #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
Here's one websocket lib making the same discovery we just did with the "close" token. |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
Should we offer a configuration for websocket to satisfy behaviors of bad websocket clients? What if the naive websocket client sends a normal I wonder if we should have a configuration that can force a |
|
Looks like |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
reviewed
Aug 25, 2021
jetty-http/src/main/java/org/eclipse/jetty/http/HttpGenerator.java
Outdated
Show resolved
Hide resolved
gregw
changed the title
gregw
requested changes
Aug 25, 2021
jetty-http/src/main/java/org/eclipse/jetty/http/HttpGenerator.java
Outdated
Show resolved
Hide resolved
gregw
reviewed
Aug 26, 2021
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…nnection Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Aug 29, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java
Outdated
Show resolved
Hide resolved
… response. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Aug 31, 2021
lachlan-roberts
deleted the
jetty-10.0.x-6642-WebSocketConnectionHeaders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6642
add tests for WebSocket Connection Headers.