Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How Can modify header value in intial request in Request class or HttpChannel in Websocket server - Jetty11 #6645

Closed
ssk512 opened this issue Aug 19, 2021 · 4 comments

Comments

@ssk512
Copy link

ssk512 commented Aug 19, 2021

Jetty version :11

Java version :11

Question
How Can modify header value in intial request in Request class or HttpChannel in Websocket server

@lachlan-roberts
Copy link
Contributor

I'm assuming this is related to jetty-project/embedded-jetty-websocket-examples#58, and you are trying to work around the fact that the client is sending Connection: close, Upgrade header which is closing the underlying connection after it has been upgraded to websocket.

I don't know how to workaround this other than removing the close from the header on the client side. I experimented with removing it with the RewriteHandler but its too late and the connection is still closed. @gregw any ideas?

@lachlan-roberts
Copy link
Contributor

@ssk512 we are working on this for issue #6642 and have a PR up to fix this in Jetty-10/11 (see #6657).

@ssk512
Copy link
Author

ssk512 commented Aug 27, 2021

@lachlan-roberts Thanks for update, please let me know once it ready

@lachlan-roberts lachlan-roberts added this to To do in Jetty 10.0.7/11.0.7 FROZEN via automation Aug 31, 2021
@lachlan-roberts
Copy link
Contributor

This has been fixed in the current 10.0.x/11.0.x branches and will be available in the next releases 10.0.7/11.0.7.

Jetty 10.0.7/11.0.7 FROZEN automation moved this from To do to Done Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants