Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6562 last written bytebuffer #6563

Merged
merged 3 commits into from Aug 3, 2021
Merged

Fix #6562 last written bytebuffer #6563

merged 3 commits into from Aug 3, 2021

Commits on Jul 30, 2021

  1. Fix #6562 last written bytebuffer 

    Fixes #6562 the last written bytebuffer calculation.
Also fixed an associated issue with unnecessary flush of an empty when last calculation already signalled last.

The code coverage is not complete, so more tests are needed for this use case. Also strange that `write(ByteBuffer)` does not appear to every commence aggregation?
    @gregw
    gregw committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    8539e1c View commit details
    Browse the repository at this point in the history

  2. Fix #6562 last written bytebuffer 

    Removed the last flush of an empty buffer as was no path to that code.
    @gregw
    gregw committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    6d2c57c View commit details
    Browse the repository at this point in the history

  3. Fix #6562 last written bytebuffer 

    Restored the last flush of an empty buffer as is needed for 0 length empty write.
    @gregw
    gregw committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    0f6d3e2 View commit details
    Browse the repository at this point in the history