Fix #6562 last written bytebuffer #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6562 the last written bytebuffer calculation. Also fixed an associated issue with unnecessary flush of an empty when last calculation already signalled last. The code coverage is not complete, so more tests are needed for this use case. Also strange that `write(ByteBuffer)` does not appear to every commence aggregation?
Removed the last flush of an empty buffer as was no path to that code.
|
@lorban @lachlan-roberts In an attempt to get 100% code coverage, I could not find a path to get to the final last emptybuffer write. So I have removed it and I think it is good. But give me extra good review on that deletion. |
lorban
requested changes
Jul 30, 2021
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from In progress
to Review in progress
Jul 30, 2021
Restored the last flush of an empty buffer as is needed for 0 length empty write.
lorban
approved these changes
Aug 2, 2021
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Review in progress
to Reviewer approved
Aug 2, 2021
gregw
added a commit
that referenced
this pull request
Aug 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6562 the last written bytebuffer calculation.
Also fixed an associated issue with unnecessary flush of an empty when last calculation already signalled last.