Issue #6544 - Fixing broken jetty.gzip.excludedMimeTypeList property support
#6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y support + Adding GzipHandler tests + Adding Gzip module tests + Updating jetty-gzip.xml for includedMimeTypesList and excludedMimeTypesList behavior + Adding GzipHandler support for setIncludedMimeTypesList(String) and setExcludedMimeTypesList(String Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
Note: this PR does not need to be backported to 9.4.x, as 9.4.x does not support a property to include/exclude by mimetype. |
gregw
previously approved these changes
Jul 30, 2021
| @@ -18,8 +18,8 @@ | |||
| <Set name="dispatcherTypes" property="jetty.gzip.dispatcherTypes"/> | |||
| <Set name="includedMethodList" property="jetty.gzip.includedMethodList"/> | |||
| <Set name="excludedMethodList" property="jetty.gzip.excludedMethodList"/> | |||
| <Set name="includedMimeTypes" property="jetty.gzip.includedMimeTypeList"/> | |||
| <Set name="excludedMimeTypes" property="jetty.gzip.excludedMimeTypeList"/> | |||
There was a problem hiding this comment.
If these methods did not exist, then the changes from #6398 should have detected that???
There was a problem hiding this comment.
Ah they did exist, they just had the wrong signature.
| <Set name="includedMimeTypes" property="jetty.gzip.includedMimeTypeList"/> | ||
| <Set name="excludedMimeTypes" property="jetty.gzip.excludedMimeTypeList"/> | ||
| <Set name="includedMimeTypesList" property="jetty.gzip.includedMimeTypeList"/> | ||
| <Set name="excludedMimeTypesList" property="jetty.gzip.excludedMimeTypeList"/> |
There was a problem hiding this comment.
I would have preferred to split the string in the XML, but we can't if we maintain the property attribute ability to not set if not set.
sbordet
requested changes
Jul 30, 2021
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/GzipHandlerTest.java
Outdated
Show resolved
Hide resolved
tests/test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/GzipModuleTests.java
Outdated
Show resolved
Hide resolved
tests/test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/GzipModuleTests.java
Outdated
Show resolved
Hide resolved
tests/test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/GzipModuleTests.java
Outdated
Show resolved
Hide resolved
tests/test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/GzipModuleTests.java
Outdated
Show resolved
Hide resolved
tests/test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/GzipModuleTests.java
Outdated
Show resolved
Hide resolved
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Reviewer approved
to Review in progress
Jul 30, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
…6544-gziphandler-excludedMimeTypes
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Review in progress
to Reviewer approved
Jul 30, 2021
sbordet
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includedMimeTypesList and
excludedMimeTypesList behavior
setIncludedMimeTypesList(String) and
setExcludedMimeTypesList(String
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com