Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A custom mimetype should be able to be excluded from gzip #6637

Closed
janbartel opened this issue Aug 18, 2021 · 5 comments
Closed

A custom mimetype should be able to be excluded from gzip #6637

janbartel opened this issue Aug 18, 2021 · 5 comments
Assignees
Labels
Documentation Stale For auto-closed stale issues and pull requests

Comments

@janbartel
Copy link
Contributor

**9.4 onwards **

Currently, if a new mimetype is specified in web.xml it is not able to be excluded from the GzipHandler. It should be possible for custom mimetypes defined in web.xml to be able to be excluded from being gzipped.

Related to: #6545

@janbartel janbartel added the Bug For general bugs on Jetty side label Aug 18, 2021
@joakime
Copy link
Contributor

joakime commented Aug 18, 2021

I think this is a duplicate of issue #6544

The fix and testcase are in PR #6550

https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-servlet/src/test/java/org/eclipse/jetty/servlet/GzipHandlerTest.java#L827-L870

It was not backported to Jetty 9.4.x, as it has no ability to include/exclude by mime-type, that's a new feature introduced for Jetty 10.0.x

@janbartel
Copy link
Contributor Author

@joakime ok, so then this needs to become a documentation exercise, as I don't see any info on how to exclude mimetypes (including ones that have been added from web.xml) from the GzipHandler.

@janbartel janbartel added Documentation and removed Bug For general bugs on Jetty side labels Sep 2, 2021
@WalkerWatch WalkerWatch assigned janbartel and unassigned WalkerWatch Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This issue has been closed due to it having no activity.

@github-actions github-actions bot closed this as completed Feb 3, 2023
@joakime
Copy link
Contributor

joakime commented Feb 3, 2023

Fixed in PR #6550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Stale For auto-closed stale issues and pull requests
Projects
None yet
Development

No branches or pull requests

3 participants