Fixed #6375 XmlConfiguration always checks for setter method #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #6375 by making XmlConfiguration Set handling always check for a matching setter, even if the property attribute is given but not set. Signed-off-by: Greg Wilkins <gregw@webtide.com>
Jetty 10.0.6/11.0.6 FROZEN
automation
moved this from In progress
to Review in progress
Jun 11, 2021
janbartel
requested changes
Jun 11, 2021
Also check for public fields Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
commented
Jun 12, 2021
jetty-xml/src/test/java/org/eclipse/jetty/xml/XmlConfigurationTest.java
Outdated
Show resolved
Hide resolved
…Test.java fixed formatting
…lipse/jetty.project into jetty-10.0.x-6375-xmlSetWithWrongName
Jetty 10.0.6/11.0.6 FROZEN
automation
moved this from Review in progress
to Reviewer approved
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6375 by making XmlConfiguration Set handling always check for a matching setter, even if the property attribute is given but not set.
Signed-off-by: Greg Wilkins gregw@webtide.com