Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Servlet 5 Schema redirects #5765

Merged
merged 6 commits into from Dec 8, 2020
Merged

Fix Servlet 5 Schema redirects #5765

merged 6 commits into from Dec 8, 2020

Conversation

janbartel
Copy link
Contributor

Closes #5752

@janbartel janbartel self-assigned this Dec 7, 2020
@janbartel janbartel added this to In progress in Jetty 11.0.0 via automation Dec 7, 2020
@janbartel janbartel linked an issue Dec 7, 2020 that may be closed by this pull request
Fix Servlet 5 Schema redirects #5752
Closed
@joakime joakime removed this from In progress in Jetty 11.0.0 Dec 7, 2020
@joakime joakime added this to In progress in Jetty 11.0.1 via automation Dec 7, 2020
@joakime joakime moved this from In progress to Review in progress in Jetty 11.0.1 Dec 7, 2020
gregw
gregw approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some minor niggles - LGTM

...-quickstart/src/main/java/org/eclipse/jetty/quickstart/QuickStartGeneratorConfiguration.java Outdated Show resolved Hide resolved
...-quickstart/src/main/java/org/eclipse/jetty/quickstart/QuickStartGeneratorConfiguration.java Outdated Show resolved Hide resolved
Jetty 11.0.1 automation moved this from Review in progress to Reviewer approved Dec 8, 2020
janbartel and others added 2 commits December 8, 2020 14:45
@janbartel @gregw
Update jetty-quickstart/src/main/java/org/eclipse/jetty/quickstart/Qu…
c5171a3 
…ickStartGeneratorConfiguration.java

Co-authored-by: Greg Wilkins <gregw@webtide.com>
@janbartel @gregw
Update jetty-quickstart/src/main/java/org/eclipse/jetty/quickstart/Qu…
21420a3 
…ickStartGeneratorConfiguration.java

Co-authored-by: Greg Wilkins <gregw@webtide.com>
joakime
joakime approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joakime joakime changed the title Jetty 11.0.x 5752 fix servlet 5 schemas Fix Servlet 5 Schema redirects Dec 8, 2020
@janbartel janbartel merged commit c4f8afc into jetty-11.0.x Dec 8, 2020
Jetty 11.0.1 automation moved this from Reviewer approved to Done Dec 8, 2020
@janbartel janbartel deleted the jetty-11.0.x-5752-jsp-xsd-redirects branch December 8, 2020 15:24
@janbartel janbartel mentioned this pull request Dec 8, 2020
Closed
@olamy olamy mentioned this pull request Jul 25, 2021
Merged
@olamy olamy mentioned this pull request Sep 30, 2021
Merged
@olamy olamy mentioned this pull request May 6, 2022
Merged
@olamy olamy mentioned this pull request May 26, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this pull request Aug 13, 2022
Merged
@olamy olamy mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime joakime approved these changes

Assignees

@janbartel janbartel

Labels
None yet
Projects
No open projects
Jetty 11.0.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Servlet 5 Schema redirects
3 participants
@janbartel @gregw @joakime