Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5761 Remove unnecessary dependencies from apache-jsp #5762

Merged
merged 1 commit into from Dec 14, 2020
Merged

Issue #5761 Remove unnecessary dependencies from apache-jsp #5762

merged 1 commit into from Dec 14, 2020

Conversation

janbartel
Copy link
Contributor

Closes #5761

@janbartel
Issue #5761 Remove unnecessary dependencies from apache-jsp
8cfa07e 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel added this to In progress in Jetty 11.0.0 via automation Dec 7, 2020
@janbartel janbartel linked an issue Dec 7, 2020 that may be closed by this pull request
Remove unneeded dependencies from apache-jsp module #5761
Closed
@janbartel janbartel self-assigned this Dec 7, 2020
@joakime joakime added this to In progress in Jetty 11.0.1 via automation Dec 7, 2020
@joakime joakime removed this from In progress in Jetty 11.0.0 Dec 7, 2020
@joakime joakime moved this from In progress to Review in progress in Jetty 11.0.1 Dec 7, 2020
Jetty 11.0.1 automation moved this from Review in progress to Reviewer approved Dec 10, 2020
joakime
joakime approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbartel janbartel merged commit c5e5f89 into jetty-11.0.x Dec 14, 2020
Jetty 11.0.1 automation moved this from Reviewer approved to Done Dec 14, 2020
@janbartel janbartel deleted the jetty-11.0.x-5761-clean-apache-jsp-pom branch December 14, 2020 09:20
@janbartel janbartel mentioned this pull request Dec 30, 2020
Closed
@olamy olamy mentioned this pull request Jul 25, 2021
Merged
@olamy olamy mentioned this pull request Sep 30, 2021
Merged
@olamy olamy mentioned this pull request May 6, 2022
Merged
@olamy olamy mentioned this pull request May 26, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this pull request Aug 13, 2022
Merged
@olamy olamy mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@olamy olamy Awaiting requested review from olamy

Assignees

@janbartel janbartel

Labels
None yet
Projects
No open projects
Jetty 11.0.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unneeded dependencies from apache-jsp module
2 participants
@janbartel @joakime