Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements client-side handling of RST_STREAM(NO_ERROR) in HTTP/2. #11054

Open
wants to merge 6 commits into
base: jetty-12.0.x
Choose a base branch
from
Open

Implements client-side handling of RST_STREAM(NO_ERROR) in HTTP/2. #11054

wants to merge 6 commits into from

Commits on Dec 13, 2023

  1. Implemented proper handling of RST_STREAM(NO_ERROR) in HTTP/2. 

    HTTP/3 could have the same handling, but apparently there is no way to receive a RESET_STREAM or STOP_SENDING frame in Quiche.

Now when receiving a RST_STREAM(NO_ERROR), it is not treated as a failure.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e04872d View commit details
    Browse the repository at this point in the history

  2. Fixed test assertion. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d470488 View commit details
    Browse the repository at this point in the history

  3. Fixed checkstyle. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3cce57c View commit details
    Browse the repository at this point in the history

  4. Added tests for 100 Continue, redirect and authentication. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8d30969 View commit details
    Browse the repository at this point in the history

  5. Avoid that the client sends a RST_STREAM to the server if the respons… 

    …e completed successfully.

Also, disposing the stream if the request failed, as we cannot rely on the RST_STREAM sent by the server.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    375047a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'jetty-12.0.x' into fix/jetty-12/reset-no-error

    @gregw
    gregw committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    5d58eff View commit details
    Browse the repository at this point in the history