Implements client-side handling of RST_STREAM(NO_ERROR) in HTTP/2. #11054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP/3 could have the same handling, but apparently there is no way to receive a RESET_STREAM or STOP_SENDING frame in Quiche. Now when receiving a RST_STREAM(NO_ERROR), it is not treated as a failure. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…e completed successfully. Also, disposing the stream if the request failed, as we cannot rely on the RST_STREAM sent by the server. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
reviewed
Dec 13, 2023
| @@ -775,6 +775,12 @@ public void close() | |||
| } | |||
| } | |||
|
|
|||
| public boolean dispose() | |||
There was a problem hiding this comment.
javadoc please.
Does it need to be public?
| @@ -494,16 +494,17 @@ public void succeeded() | |||
| { | |||
| if (LOG.isDebugEnabled()) | |||
| LOG.debug("HTTP3 Response #{}/{}: unconsumed request content, resetting stream", stream.getId(), Integer.toHexString(stream.getSession().hashCode())); | |||
| stream.reset(HTTP3ErrorCode.REQUEST_CANCELLED_ERROR.code(), new IOException("unconsumed content")); | |||
| stream.reset(HTTP3ErrorCode.NO_ERROR.code(), new IOException("unconsumed content")); | |||
There was a problem hiding this comment.
why not use CONTENT_NOT_CONSUMED?
gregw
requested changes
Dec 15, 2023
|
@sbordet how about in this release cycle we only change the server side to send the reset(NO_ERROR) and leave the client side as is. |
sbordet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/3 could have the same handling, but apparently there is no way to receive a RESET_STREAM or STOP_SENDING frame in Quiche.
Now when receiving a RST_STREAM(NO_ERROR), it is not treated as a failure.