Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly resolve artifact types #1836

Merged
merged 1 commit into from Apr 10, 2019
Merged

properly resolve artifact types #1836

merged 1 commit into from Apr 10, 2019

Conversation

guidoschreuder
Copy link
Contributor

Fixes Issue

Test dependencies were not properly resolved when scanning section

Description of Change

Use ArtifactTypeRegistry from Maven Session to properly resolve artifact types

Have test cases been added to cover the new functionality?

no

@guidoschreuder
Copy link
Contributor Author

Hi @jeremylong
This is a follow-up on my previous PR #1552 , discovered this issue while testing
If you want me to create a ticket for this, please let me know

@guidoschreuder
Copy link
Contributor Author

In short what is happening: method toDependencyNode is trying to fetch some-artifact-0.0.1.test-jar instead of some-artifact-0.0.1-tests.jar

@jeremylong jeremylong merged commit 95dfbd8 into jeremylong:master Apr 10, 2019
@guidoschreuder guidoschreuder deleted the improved-artifact-resolution-for-dependency-management-scanning branch April 10, 2019 14:43
@jeremylong jeremylong added this to the 5.0.0-M3 milestone May 6, 2019
@ddellspe ddellspe mentioned this pull request Oct 2, 2019
Closed
@lock lock bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-M3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guidoschreuder @jeremylong