Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue resolving non-test dependency with classifier #2231

Closed
ddellspe opened this issue Oct 2, 2019 · 0 comments
Closed

Issue resolving non-test dependency with classifier #2231

ddellspe opened this issue Oct 2, 2019 · 0 comments
Labels
Milestone

Comments

@ddellspe
Copy link
Contributor

ddellspe commented Oct 2, 2019

Reporting Bugs/Errors

When reporting errors, 99% of the time log file output is required. Please post the log file as a gist and provide a link in the new issue.

Example of library

Library that fails to pull in appropriately

<dependency>
    <groupId>org.jbehave</groupId>
    <artifactId>jbehave-core</artifactId>
    <version>4.3.5</version>
    <type>zip</type>
    <classifier>resources</classifier>
</dependency>

General Problem Description

I found the issue where this comes from related to PR #1836 Based on my check-over of ArtifactType it looks like it's only set if there's a default for that scope. I'll see if I can get a build of this doing some logic based on the getClassifier() output as the dependency value should override that of the classifier in the ArtifactType output.

The updated version (we were previously on 4.0.2) resolved correctly as org.jbehave:jbehave-core-4.3.5-resources.zip it currently resolves to org.jbehave:jbehave-core-4.3.5.zip skipping the classifier

@jeremylong jeremylong added this to the 5.2.3 milestone Nov 11, 2019
@lock lock bot locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants