Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test harness #191

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Update test harness #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33d757a
Update test harness
basil Mar 20, 2022
2784809
Incrementalify plugin
basil Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 6 additions & 12 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ under the License.
<version>${revision}.${changelist}</version>
<packaging>hpi</packaging>
<name>SAML Plugin</name>
<url>https://github.com/jenkinsci/saml-plugin</url>
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the artifact will never change, and the change is unrelated to the bump of the test harness dependency, however, the change is innocuous so we can keep it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the artifact will never change, and the change is unrelated to the bump of the test harness dependency, however, the change is innocuous so we can keep it.

Sorry, I should have been more descriptive about this change. This was needed so I could test the incremental build with Plugin Compatibility Tester (PCT). Please see the following links:


<scm>
<connection>scm:git:git://github.com/jenkinsci/saml-plugin.git</connection>
<developerConnection>scm:git:git@github.com:jenkinsci/saml-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/saml-plugin</url>
<connection>scm:git:git://github.com/${gitHubRepo}.git</connection>
<developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection>
<url>https://github.com/${gitHubRepo}</url>
<tag>${scmTag}</tag>
</scm>

Expand All @@ -46,7 +46,7 @@ under the License.
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.303.3</jenkins.version>
<java.level>8</java.level>
<jenkins-test-harness.version>1498.v53acb0fd4634</jenkins-test-harness.version>
basil marked this conversation as resolved.
Show resolved Hide resolved
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
</properties>

<licenses>
Expand Down Expand Up @@ -237,12 +237,6 @@ under the License.
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.jenkins-ci.main</groupId>
<artifactId>jenkins-test-harness</artifactId>
<version>1721.v385389722736</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
Expand All @@ -265,7 +259,7 @@ under the License.
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.303.x</artifactId>
<version>1198.v387c834fca_1a_</version>
<version>1210.vcd41f6657f03</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down