Update test harness #191
Update test harness #191
Conversation
|
The incremental build from this PR has been successfully tested with Java 17 in the draft PR jenkinsci/bom#935. In order to help facilitate the transition of that draft PR into non-draft status, it would be helpful for this PR to be merged and released. |
| @@ -32,12 +32,12 @@ under the License. | |||
| <version>${revision}.${changelist}</version> | |||
| <packaging>hpi</packaging> | |||
| <name>SAML Plugin</name> | |||
| <url>https://github.com/jenkinsci/saml-plugin</url> | |||
| <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> | |||
There was a problem hiding this comment.
the artifact will never change, and the change is unrelated to the bump of the test harness dependency, however, the change is innocuous so we can keep it.
There was a problem hiding this comment.
the artifact will never change, and the change is unrelated to the bump of the test harness dependency, however, the change is innocuous so we can keep it.
Sorry, I should have been more descriptive about this change. This was needed so I could test the incremental build with Plugin Compatibility Tester (PCT). Please see the following links:
- JENKINS-58716
- [JENKINS-58716] Using gitHubRepo archetypes#192
- [JENKINS-58716] -DgitHubRepo when possible to infer incrementals-tools#16
- [JENKINS-58716] Support checking out plugins with Incremental versions plugin-compat-tester#181
- [JENKINS-58716] /project/scm/url may now point to a fork; relax check jenkins-infra/community-functions#23
|
Thank you for the quick release! |
Amends #190. Sorry for the second PR. The main thing I was trying to upgrade in #190 was the test harness, which I thought I was doing by bumping the plugin parent POM. But today I realized this plugin was defining its own custom test harness version. This PR removes that in favor of the test harness version defined in the plugin parent POM, which as of 4.38 is the very latest Jenkins test harness.
As a bonus I also updated the plugin BOM to the latest version.
A release of this would help us do Java 17 testing of this plugin. CC @kuisathaverat