Update plugins

[batmat]

Just made a pass of versions:display-plugins-updates.

Successful downstream PR builds with timestamped SNAPSHOT on the following components (1.51-20181206.212314-4):

• Jenkins Core [DO NOT MERGE] Test parent pom with a bunch of plugins updates jenkins#3785 (PR failed, but on unrelated tests only)
• Remoting [DO NOT MERGE] test updated parent remoting#310
• Winstone DO NOT MERGE: test updated parent winstone#59
• Plugin Compat Tester DO NOT MERGE Test updated parent pom plugin-compat-tester#91

Output was:

INFO] The following plugin updates are available:
[INFO]   io.jenkins.tools.incrementals:incrementals-maven-plugin  1.0-beta-5 -> 1.0-beta-7
[INFO]   maven-checkstyle-plugin ............................... 2.17 -> 3.0.0
[INFO]   maven-clean-plugin ................................... 3.0.0 -> 3.1.0
[INFO]   maven-dependency-plugin .............................. 3.0.2 -> 3.1.1
[INFO]   maven-deploy-plugin ............................... 2.8.2 -> 3.0.0-M1
[INFO]   maven-enforcer-plugin .......................... 3.0.0-M1 -> 3.0.0-M2
[INFO]   maven-help-plugin .................................... 3.0.1 -> 3.1.0
[INFO]   maven-idea-plugin ........................... 2.2 -> 2.3-atlassian-10
[INFO]   maven-install-plugin .............................. 2.5.2 -> 3.0.0-M1
[INFO]   maven-jar-plugin ..................................... 3.0.2 -> 3.1.0
[INFO]   maven-jxr-plugin ....................................... 2.5 -> 3.0.0
[INFO]   maven-pmd-plugin ...................................... 3.8 -> 3.11.0
[INFO]   maven-project-info-reports-plugin ...................... 2.9 -> 3.0.0
[INFO]   maven-remote-resources-plugin .......................... 1.5 -> 1.6.0
[INFO]   maven-resources-plugin ............................... 3.0.2 -> 3.1.0
[INFO]   maven-site-plugin ...................................... 3.7 -> 3.7.1
[INFO]   maven-surefire-plugin .............................. 2.20 -> 3.0.0-M1
[INFO]   maven-surefire-report-plugin ....................... 2.20 -> 3.0.0-M1
[INFO]   maven-war-plugin ..................................... 3.1.0 -> 3.2.2
[INFO]   org.codehaus.cargo:cargo-maven2-plugin ............... 1.1.2 -> 1.7.0
[INFO]   org.codehaus.mojo:gwt-maven-plugin ................. 2.3.0-1 -> 2.8.2
[INFO]   org.codehaus.mojo:versions-maven-plugin .................. 2.5 -> 2.7
[INFO]   org.codehaus.mojo:xml-maven-plugin ..................... 1.0 -> 1.0.2
[INFO]   org.jenkins-ci.tools:maven-hpi-plugin .................... 2.3 -> 2.7
[INFO]   org.jvnet.maven-antrun-extended-plugin:maven-antrun-extended-plugin  1.42 -> 1.43
[INFO]   org.mortbay.jetty:maven-jetty-plugin ........... 6.1.26 -> 7.0.0.pre5

[olamy]

do we really use idea or cargo or gwt plugins? We can probably get rid of those?

[jtnord]

the deploy plugin scares me a little bit and I think would be a blocker for the CERT team

https://issues.apache.org/jira/browse/MDEPLOY-244

[jtnord]

deploy plugin issue https://issues.apache.org/jira/browse/MDEPLOY-244

[batmat]

Fine by me. This PR also definitely was intended to actually gather that feedback and still try to attempt as many components as we can. Going to revert m-deploy-p and Surefire related bumps and ask again for review. We'll reconsider these possibly later.

[batmat]

@oleg-nenashev @jtnord I reverted m-surefire-*-p and m-deploy-p. Care to re-review?

Also pushed a new timestamped SNAPSHOT 1.51-20181203.164412-3 into jenkinsci/jenkins#3785 to test its behavior.

Thanks

[oleg-nenashev]

I literally have no idea what is going to blow up there. Looks good, 🚢 🇮🇹

Speaking seriously, we have enough time to cleanup the things before the next LTS baseline if something goes wrong. +1 from me from merging once there are downstream pull requests with the update pickup to...

• Jenkins Core
• Remoting
• Winstone
• Plugin Compat Tester

It should give us enough blow-up coverage taking the recent experience with upgrades

[oleg-nenashev]

LGTM. Worth retrying several builds with checkstyle/coverage profiles on Java 8 and Java 11 after merging

[batmat]

All upstream PRs filed @oleg-nenashev. We'll see how they go.

[batmat]

All downstream PRs successful. Merging given the review approvals.