Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins #137

Merged
merged 17 commits into from
Dec 8, 2018
Merged

Update plugins #137

merged 17 commits into from
Dec 8, 2018

Conversation

batmat
Copy link
Member

@batmat batmat commented Dec 2, 2018

Round of plugins update based on versions:display-plugins-updates, similar to jenkinsci/pom#37

I left aside:

Output was:

[INFO] The following plugin updates are available:
[INFO]   com.github.eirslett:frontend-maven-plugin .............. 1.4 -> 1.6
[INFO]   maven-clean-plugin ................................. 3.0.0 -> 3.1.0
[INFO]   maven-compiler-plugin .............................. 3.6.1 -> 3.8.0
[INFO]   maven-dependency-plugin ............................ 3.0.0 -> 3.1.1
[INFO]   maven-deploy-plugin ............................. 2.8.2 -> 3.0.0-M1
[INFO]   maven-enforcer-plugin ........................ 3.0.0-M1 -> 3.0.0-M2
[INFO]   maven-failsafe-plugin .......................... 2.19.1 -> 3.0.0-M1
[INFO]   maven-install-plugin ............................ 2.5.2 -> 3.0.0-M1
[INFO]   maven-invoker-plugin ............................... 2.0.0 -> 3.1.0
[INFO]   maven-jar-plugin ................................... 3.0.2 -> 3.1.0
[INFO]   maven-javadoc-plugin .............................. 2.10.4 -> 3.0.1
[INFO]   maven-resources-plugin ............................. 3.0.2 -> 3.1.0
[INFO]   maven-scm-plugin .................................. 1.9.5 -> 1.11.1
[INFO]   maven-surefire-plugin ............................ 2.20 -> 3.0.0-M1
[INFO]   maven-war-plugin ................................... 3.0.0 -> 3.2.2
[INFO]   org.codehaus.mojo:mrm-maven-plugin ................. 1.0.1 -> 1.1.0
[INFO]   org.jacoco:jacoco-maven-plugin ..................... 0.7.9 -> 0.8.1
[INFO]   org.kohsuke:access-modifier-checker .................. 1.15 -> 1.16

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking the experience with https://github.com/jenkinsci/plugin-pom/pull/131/files and JEP-200 regressions in the tests, I suspect that this update is also going to cause it

@oleg-nenashev
Copy link
Member

apache/maven-surefire@f5cca5b needs to be released before we can consider the update

@batmat
Copy link
Member Author

batmat commented Dec 3, 2018

@oleg-nenashev I reverted surefire and failsafe updates.

@batmat
Copy link
Member Author

batmat commented Dec 3, 2018

3.29-20181203.165022-9 is the new timestamped SNAPSHOT. Updating the related jenkinsci/git-plugin#641 test PR.

@batmat
Copy link
Member Author

batmat commented Dec 4, 2018

Git-plugin PR is successful jenkinsci/git-plugin#641 FTR.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven Deploy needs to be reverted, preferably with a TODO comment.
The rest LGTM

</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.6.1</version>
<version>3.8.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally needed for support of higher Java levels. Also updated in #133

pom.xml Outdated Show resolved Hide resolved
This reverts commit eddf94f.

Also added a note as to why/until what this upgrade must be postponed.
@batmat
Copy link
Member Author

batmat commented Dec 6, 2018

@oleg-nenashev reverted the m-deploy-p bump with a comment. Care to have another look? Thanks

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good

@oleg-nenashev oleg-nenashev merged commit bd2a811 into jenkinsci:master Dec 8, 2018
@batmat batmat deleted the update-plugins branch December 8, 2018 11:44
@oleg-nenashev
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants