Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-20679] - Inject Minimum-Java-Version into the plugin manifest #134

Merged
merged 3 commits into from
Dec 5, 2018

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Nov 23, 2018

Downstream of jenkinsci/maven-hpi-plugin#75 . It is a more simple version of #133 which should unblock the feature while java.level=11 is not fully supported. So you still build plugins which are formally Java 8 compliant (source/target), but you can require Java 11 due to whatever reason.

Consumer of the pull request: jenkins-infra/update-center2#253

@jenkinsci/java11-support

@oleg-nenashev
Copy link
Member Author

3.29-20181203.151310-8 is the new deployment

Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jglick
Copy link
Member

jglick commented Dec 4, 2018

  • By default, injects versions like 1.8 or 1.7
  • Can be overridden to produce 11 for Java 11.

This seems extremely confusing to me. Why can we not just say it always injects versions in the now-preferred format: 7, 8, 11, etc.?

@oleg-nenashev
Copy link
Member Author

This seems extremely confusing to me. Why can we not just say it always injects versions in the now-preferred format: 7, 8, 11, etc.?

It follows Java specification formats in https://openjdk.java.net/jeps/223 (new ones for modern Javas and old ones for 8 and older)

@oleg-nenashev
Copy link
Member Author

@jenkinsci/java11-support should be ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants