[JENKINS-20679] Try to declare the minimum Java version in the manifest

[daniel-beck]

JENKINS-20679

Only tested manually, including with a patched plugins POM to see whether the compiler plugin configuration fallback works. Can rip that out and we only support property or HPI plugin configuration for this.

Downstream PRs are jenkins-infra/update-center2#164 and jenkinsci/jenkins#3016.

Upstream of: jenkinsci/plugin-pom#134

@jenkinsci/code-reviewers

[KostyaSha]

Unfortunately hpi-plugin is not using jar-plugin. Does maven-jar-plugin put such info? Could you compare with generic maven project with jar packaging manifest? Is it missing something else?

[daniel-beck]

@KostyaSha Not sure what you mean, could you elaborate? Also, note that I don't want to mechanically pick up whatever is used to build the plugin (may be too recent, or there may be reasons to require a newer JRE to actually run), so the Build-Jdk entry is unsuitable.

[KostyaSha]

Checked myself. Seems maven-jar is not setting this information. I thought it includes more information in manifest :/

[oleg-nenashev]

🐝 . There may be a need to check if the dependencies are compliant with the declared version, but IIRC it's already done by other tools

[daniel-beck]

@oleg-nenashev Animal sniffer and enforcer use the java.level in the plugins POM. While there may be rare situations this isn't good enough (e.g. custom parent POM/overrides), we should just treat those as bugs in the plugin (responsibility to set the HPI plugin parameter if somehow needing a newer JRE as automatically determined) and ignore it otherwise.

[jglick]

Too magical, not the Maven way.

[daniel-beck]

This change + the downstream change to plugin POM should probably done sooner rather than later.

The corresponding core change is only needed when core supports Java 9 at all, and the infra change can be implemented even later (theoretically).

[jglick]

the downstream change to plugin POM

Where is that?

[jglick]

OK so far as it goes, but needs to be evaluated in context of matching PRs.

[jglick]

Is there something filed downstream of this?

[daniel-beck]

@jglick See original PR comment.

[jglick]

I think on hold while discussions in the downstreams continue.

[oleg-nenashev]

@jenkinsci/java11-support

[batmat]

LGTM, but I commented in https://github.com/jenkinsci/maven-hpi-plugin/pull/75/files#r236275067 about my main concern currently.

[oleg-nenashev]

And then Maven integration tests failed... as designed, I believe. Will add flags there

[oleg-nenashev]

There is a chicken-and-egg problem in integration tests. They fail, because minimumJavaVersion is now required as the reviewers suggested. The problem is that the tests use old versions of Plugin POM which do not include jenkinsci/plugin-pom#134 (downstream of this PR).

option 1: I could release a snapshot of the Parent POM, update integration tests to such timestamped snapshot (upper bounds, yey), and then the tests would be green. But it requires a circular dependency in the release. It should be Okay in this case

option 2: Reconsider the approach and do not require minimumJavaVersion to be always set. In such case we will have no breaking changes, and the integration tests will pass with previous plugin POMs

@jglick @daniel-beck @jenkinsci/java11-support Would appreciate an advice how to proceed

[batmat]

IMO if we step back:

• in the general case, i.e. if we don't take the current state in account, I am still convinced we should require it. It's much clearer and we can leverage this in many locations to serve better the Jenkins users by filtering out the incompatible plugins for their setup. AFAIK we all agree that this is more and more needed, if not overdue.
• anyway nobody is going to see her/his plugin start failing to build right after we merge and release the new maven-hpi-plugin. This requires an explicit version bump, and in such case said developers will just spend the needed 5 seconds to decide what minimum Java version they are actually supporting, done.
• The ITs here are obviously a special case, and are failing exactly for the contrary reason as the previous point: this uses the latest version of the maven-hpi-plugin on an old plugin. Which in real life would be no-brainer: developer adds the newly required minimumJavaVersion field, done. So despite this is a bit crappy here to have to modify existing ITs, I don't see really an other way out, so let's bite the bullet.

So, for the issue at stake here IMO this is why we should go for option 1, because requiring the field is the most important and the right long-term decision.

[MRamonLeon]

I prefer the option 1.

[jglick]

Alternately, make the Java version optional (with a warning) for now, release everything, then immediately afterward go back and make it mandatory by switching the parent POMs in the ITs to use the prior release.

[oleg-nenashev]

Deployed the current state as 3.0-20181203.145945-2

[oleg-nenashev]

Going forward with option 1

[oleg-nenashev]

@jenkinsci/java11-support @jglick The rest of integration tests are failing with...

[WARNING] Could not validate integrity of download from https://repo.jenkins-ci.org/public/org/jenkins-ci/tools/maven-hpi-plugin/3.0-SNAPSHOT/maven-hpi-plugin-3.0-20181203.145945-2.pom.sha1: Checksum validation failed, no checksums available

[WARNING] Could not validate integrity of download from https://repo.jenkins-ci.org/public/org/jenkins-ci/tools/maven-hpi-plugin/3.0-SNAPSHOT/maven-hpi-plugin-3.0-20181203.145945-2.jar.sha1: Checksum validation failed, no checksums available

[INFO] ..FAILED (44.9 s)

I cannot do much about that, so I suggest merging as is and then fixing the PR builder after releasing the downstream patch and bumping to the released version of Plugin POM. Are you fine with it?

[batmat]

You mean releasing the plugin-pom jenkinsci/plugin-pom#134. I guess let's do that, yes.

[jglick]

Huh? That JEP seems to say the format should be 6, 7, etc., and not 1.6, 1.7, etc. as before. So which is the version format expected by this feature?

[oleg-nenashev]

https://openjdk.java.net/jeps/223 . 1.6 and 1.7 are the old formats of Java specification, we should not maintain them going forward imho

[jglick]

Right, so why would we support them at all in this newly added feature?

[oleg-nenashev]

Maven release failed due to the duplicate metadata file, but I see it for other Maven Plugins in Jenkins org as well. The release itself should be fine

[INFO] [INFO] --- maven-deploy-plugin:2.6:deploy (default-deploy) @ maven-hpi-plugin ---
[INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.0/maven-hpi-plugin-3.0.jar
[INFO] Progress (1): 2.0/140 kB
[INFO] Progress (1): 4.1/140 kB
[INFO] Progress (1): 6.1/140 kB
[INFO] Progress (1): 8.2/140 kB
[INFO] Progress (1): 10/140 kB 
[INFO] Progress (1): 12/140 kB
[INFO] Progress (1): 14/140 kB
[INFO] Progress (1): 16/140 kB
[INFO] Progress (1): 18/140 kB
[INFO] Progress (1): 20/140 kB
[INFO] Progress (1): 23/140 kB
[INFO] Progress (1): 25/140 kB
[INFO] Progress (1): 27/140 kB
[INFO] Progress (1): 29/140 kB
[INFO] Progress (1): 31/140 kB
[INFO] Progress (1): 33/140 kB
[INFO] Progress (1): 35/140 kB
[INFO] Progress (1): 37/140 kB
[INFO] Progress (1): 39/140 kB
[INFO] Progress (1): 41/140 kB
[INFO] Progress (1): 43/140 kB
[INFO] Progress (1): 45/140 kB
[INFO] Progress (1): 47/140 kB
[INFO] Progress (1): 49/140 kB
[INFO] Progress (1): 51/140 kB
[INFO] Progress (1): 53/140 kB
[INFO] Progress (1): 55/140 kB
[INFO] Progress (1): 57/140 kB
[INFO] Progress (1): 59/140 kB
[INFO] Progress (1): 61/140 kB
[INFO] Progress (1): 63/140 kB
[INFO] Progress (1): 66/140 kB
[INFO] Progress (1): 68/140 kB
[INFO] Progress (1): 70/140 kB
[INFO] Progress (1): 72/140 kB
[INFO] Progress (1): 74/140 kB
[INFO] Progress (1): 76/140 kB
[INFO] Progress (1): 78/140 kB
[INFO] Progress (1): 80/140 kB
[INFO] Progress (1): 82/140 kB
[INFO] Progress (1): 84/140 kB
[INFO] Progress (1): 86/140 kB
[INFO] Progress (1): 88/140 kB
[INFO] Progress (1): 90/140 kB
[INFO] Progress (1): 92/140 kB
[INFO] Progress (1): 94/140 kB
[INFO] Progress (1): 96/140 kB
[INFO] Progress (1): 98/140 kB
[INFO] Progress (1): 100/140 kB
[INFO] Progress (1): 102/140 kB
[INFO] Progress (1): 104/140 kB
[INFO] Progress (1): 106/140 kB
[INFO] Progress (1): 109/140 kB
[INFO] Progress (1): 111/140 kB
[INFO] Progress (1): 113/140 kB
[INFO] Progress (1): 115/140 kB
[INFO] Progress (1): 117/140 kB
[INFO] Progress (1): 119/140 kB
[INFO] Progress (1): 121/140 kB
[INFO] Progress (1): 123/140 kB
[INFO] Progress (1): 125/140 kB
[INFO] Progress (1): 127/140 kB
[INFO] Progress (1): 129/140 kB
[INFO] Progress (1): 131/140 kB
[INFO] Progress (1): 133/140 kB
[INFO] Progress (1): 135/140 kB
[INFO] Progress (1): 137/140 kB
[INFO] Progress (1): 139/140 kB
[INFO] Progress (1): 140 kB    
[INFO]                     
[INFO] Uploaded to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.0/maven-hpi-plugin-3.0.jar (140 kB at 69 kB/s)
[INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.0/maven-hpi-plugin-3.0.pom
[INFO] Progress (1): 2.0/12 kB
[INFO] Progress (1): 4.1/12 kB
[INFO] Progress (1): 6.1/12 kB
[INFO] Progress (1): 8.2/12 kB
[INFO] Progress (1): 10/12 kB 
[INFO] Progress (1): 12/12 kB
[INFO] Progress (1): 12 kB   
[INFO]                    
[INFO] Uploaded to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.0/maven-hpi-plugin-3.0.pom (12 kB at 15 kB/s)
[INFO] Downloading from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml
[INFO] Progress (1): 0.7/2.6 kB
[INFO] Progress (1): 2.1/2.6 kB
[INFO] Progress (1): 2.6 kB    
[INFO]                     
[INFO] Downloaded from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml (2.6 kB at 7.3 kB/s)
[INFO] Downloading from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml
[INFO] Progress (1): 385 B
[INFO]                    
[INFO] Downloaded from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml (385 B at 1.5 kB/s)
[INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml
[INFO] Progress (1): 2.0/2.5 kB
[INFO] Progress (1): 2.5 kB    
[INFO]                     
[INFO] Uploaded to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml (2.5 kB at 3.1 kB/s)
[INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml
[INFO] Progress (1): 385 B
[INFO]                    
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time:  26.541 s
[INFO] [INFO] Finished at: 2018-12-05T09:58:38+01:00
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.6:deploy (default-deploy) on project maven-hpi-plugin: Failed to deploy metadata: Could not transfer metadata org.jenkins-ci.tools/maven-metadata.xml from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): Access denied to: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml -> [Help 1]
[INFO] [ERROR] 
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR] 
[INFO] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[INFO] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

[olamy]

@oleg-nenashev nope not duplicated! but you cannot write the maven-metadata.xml (error message says Access denied to: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml ). I had the same problem recently... might be an infra issue... (not source files are probably not deploy...)

[daniel-beck]

The patterns used for upload permissions from https://github.com/jenkins-infra/repository-permissions-updater/ do not allow for a package level metadata file.

[olamy]

this is not an issue until we want to add new maven plugin.