Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump parent POM from 4.37 to 4.38 #77

Closed
wants to merge 2 commits into from
Closed

Bump parent POM from 4.37 to 4.38 #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58cb05f
Bump parent POM from 4.37 to 4.38
basil Mar 20, 2022
160458d
Incrementalify plugin
basil Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.37</version>
<version>4.38</version>
<relativePath />
</parent>

Expand All @@ -41,7 +41,7 @@
<description>
This plugin provides an stable API to Bouncy Castle related tasks.
</description>
<url>https://github.com/jenkinsci/bouncycastle-api-plugin</url>
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does incrementals need this - it is less readable and much worse IMO.

Copy link
Member Author

@basil basil Mar 21, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does incrementals need this

@jtnord Please see the following links:

Copy link
Member

@jtnord jtnord Mar 21, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very late to the party - but github (which is all we support for jenkins plugins IIUC) can checkout the sha of a commit from a fork so long as there was a PR using the non-fork repo - so this should all be unnecessary - just was missing the correct FETCH options?

pushing incrementals from non PRs is not supported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, James, but this seems like the wrong forum to debate a change that we have already rolled out to dozens of other plugins.

<licenses>
<license>
<name>The MIT license</name>
Expand All @@ -59,9 +59,9 @@
</developers>

<scm>
<connection>scm:git:git://github.com/jenkinsci/bouncycastle-api-plugin.git</connection>
<developerConnection>scm:git:git@github.com:jenkinsci/bouncycastle-api-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/bouncycastle-api-plugin</url>
<connection>scm:git:git://github.com/${gitHubRepo}.git</connection>
<developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection>
<url>https://github.com/${gitHubRepo}</url>
<tag>${scmTag}</tag>
</scm>

Expand All @@ -70,6 +70,7 @@
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.319.1</jenkins.version>
<java.level>8</java.level>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<bouncycastleVersion>1.70</bouncycastleVersion>
<useBeta>true</useBeta>
</properties>
Expand Down