Bump parent POM from 4.37 to 4.38 #77
Conversation
|
The incremental build from this PR has been successfully tested with Java 17 in the draft PR jenkinsci/bom#935. In order to help facilitate the transition of that draft PR into non-draft status, it would be helpful for this PR to be merged and released. |
| @@ -41,7 +41,7 @@ | |||
| <description> | |||
| This plugin provides an stable API to Bouncy Castle related tasks. | |||
| </description> | |||
| <url>https://github.com/jenkinsci/bouncycastle-api-plugin</url> | |||
| <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> | |||
There was a problem hiding this comment.
Why does incrementals need this - it is less readable and much worse IMO.
There was a problem hiding this comment.
Why does incrementals need this
@jtnord Please see the following links:
- JENKINS-58716
- [JENKINS-58716] Using gitHubRepo archetypes#192
- [JENKINS-58716] -DgitHubRepo when possible to infer incrementals-tools#16
- [JENKINS-58716] Support checking out plugins with Incremental versions plugin-compat-tester#181
- [JENKINS-58716] /project/scm/url may now point to a fork; relax check jenkins-infra/community-functions#23
There was a problem hiding this comment.
very late to the party - but github (which is all we support for jenkins plugins IIUC) can checkout the sha of a commit from a fork so long as there was a PR using the non-fork repo - so this should all be unnecessary - just was missing the correct FETCH options?
pushing incrementals from non PRs is not supported?
There was a problem hiding this comment.
I don't know, James, but this seems like the wrong forum to debate a change that we have already rolled out to dozens of other plugins.
|
Closing in favor of #78. |
A release of this would help us do Java 17 testing of this plugin in the plugin BOM repository. CC @jtnord