Mark bootstrap, momentjs, numeraljs, jquery-detached deprecated #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsandell
approved these changes
Jan 30, 2023
MarkEWaite
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Approved.
I believe that the ace-editor dependency from the workflow-cps plugin makes it undesirable to deprecate ace-editor until the dependency is removed from workflow-cps plugin. Since ace-editor is not being deprecated in this pull request, I see no issue with this pull request.
This is a great step. Thanks!
Shameless plug for a PR making |
|
Now that jenkinsci/workflow-cps-plugin#653 has been merged I suggest doing the same for |
This was referenced Feb 2, 2023
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These plugins have already been marked deprecated in their documentation since jenkinsci/js-libs@6906cc3:
Of these, only
jquery-detachedhas a few dependent plugins, the rest has no dependents (anymore).Given the unusual situation of a multi plugin repo without explicit deprecation URL different from documentation, I'm deprecating via
label-definitions.properties.handlebarsfrom the same GH repo was marked deprecated in #677.With this change, only https://plugins.jenkins.io/ace-editor/ has no deprecation indicator (yet).
WDYT @batmat @rsandell ?