Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support action input for release draft body #5

Merged
merged 6 commits into from Jun 13, 2022
Merged

support action input for release draft body #5

merged 6 commits into from Jun 13, 2022

Conversation

jetersen
Copy link
Collaborator

@jetersen jetersen commented Jun 3, 2022 •
edited

@jetersen jetersen mentioned this pull request Jun 3, 2022
Closed
jglick
jglick approved these changes Jun 3, 2022
View reviewed changes
run.sh Outdated Show resolved Hide resolved
@jetersen @jglick
Update run.sh
e85a17a 
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
jglick
jglick approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. Tested yet in context of the workflow?

@jglick
Copy link
Contributor

jglick commented Jun 10, 2022

TBD whether this has any effect on jenkins-infra/github-reusable-workflows#14.

This was referenced Jun 10, 2022
Merged
Merged
jglick
jglick reviewed Jun 10, 2022
View reviewed changes
Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/6838449291?check_suite_focus=true#step:4:104 the variable is not being bound

action.yaml Outdated Show resolved Hide resolved
jglick
jglick requested changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently broken

@jetersen
Copy link
Collaborator Author

@jglick fixed:
https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/6840951645?check_suite_focus=true

jetersen
jetersen commented Jun 11, 2022
View reviewed changes
action.yaml Show resolved Hide resolved
@jetersen @jglick
Update action.yaml
d670515 
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@jetersen
Copy link
Collaborator Author

This is ready to merge @jglick

@jglick jglick mentioned this pull request Jun 13, 2022
Merged
@jetersen jetersen requested a review from jglick June 13, 2022 19:24
jglick
jglick approved these changes Jun 13, 2022
View reviewed changes
action.yaml Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
@jetersen
Copy link
Collaborator Author

@jglick Resolved your suggestions :)

@jetersen
Copy link
Collaborator Author

@jglick I don't know who is maintainer on this and can merge it 😅

Perhaps @timja or one of the other infra people @lemeurherve

@jglick
Copy link
Contributor

jglick commented Jun 13, 2022

I have write access. Let me retest it.

@jglick jglick merged commit 53539d5 into jenkins-infra:main Jun 13, 2022
@jetersen jetersen deleted the patch-1 branch June 13, 2022 20:51
@jglick jglick mentioned this pull request Jun 13, 2022
Closed
@jglick
Copy link
Contributor

jglick commented Jun 13, 2022

⇒ https://github.com/jenkins-infra/interesting-category-action/releases/tag/v1.2.0

jglick added a commit to jenkins-infra/github-reusable-workflows that referenced this pull request Jun 13, 2022
@jglick
jenkins-infra/interesting-category-action#5 released
531a3c0
@lemeurherve
Copy link
Member

lemeurherve commented Jun 14, 2022 •
edited

I don't know who is maintainer on this and can merge it 😅

@jetersen would you like to be added as maintainer on this repository?

Great work on the github actions by the way, thanks!

@jetersen
Copy link
Collaborator Author

@lemeurherve sure I believe @timja already added me to the other action repos 😄

@lemeurherve
Copy link
Member

Added, you should receive an invitation shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jetersen @jglick @lemeurherve @timja