Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for release metadata to be flushed #2

Closed
wants to merge 1 commit into from
Closed

Conversation

jglick
Copy link
Collaborator

@jglick jglick commented Jun 2, 2022

@jglick
Copy link
Collaborator Author

jglick commented Jun 3, 2022

Seems to work https://github.com/jenkinsci/jenkins-infra-test-plugin/releases/tag/62.v0d4f02c3969f or maybe it was just working again by accident anyway.

Alternately, https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/6716516319?check_suite_focus=true#step:3:77 I guess we could try to read the body output from Release Drafter. Would require changes to the interesting changes action; and I am not sure that would improve correctness in corner cases like when backport branches are in use.

@jetersen
Copy link
Collaborator

jetersen commented Jun 3, 2022

jenkins-infra/interesting-category-action#5

Should be able to use it as well

      - name: Release Drafter
        uses: release-drafter/release-drafter@v5
        id: draft
        if: steps.verify-ci-status.outputs.result == 'success'
        with:
          name: next
          tag: next
          version: next
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

      - name: Check interesting categories
        uses: jetersen/interesting-category-action@patch-1
        id: interesting-categories
        if: steps.verify-ci-status.outputs.result == 'success'
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          RELEASE_DRAFT_BODY: ${{ steps.draft.outputs.body }}  

@jglick
Copy link
Collaborator Author

jglick commented Jun 3, 2022

Do you care to prepare a branch of the workflow picking up your action patch and piping the output of the R.D. action to it? Then we can test it in an amendment to jenkinsci/jenkins-infra-test-plugin#21.

@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

Prefer #3.

@jglick jglick closed this Jun 13, 2022
@jglick jglick deleted the race-condition branch June 13, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants