Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use steps.draft.outputs.body #3

Merged
merged 2 commits into from Jun 13, 2022
Merged

Use steps.draft.outputs.body #3

merged 2 commits into from Jun 13, 2022

Conversation

jglick
Copy link
Collaborator

@jglick jglick commented Jun 10, 2022

@jglick jglick requested review from jetersen and timja June 10, 2022 21:34
@jglick jglick marked this pull request as draft June 10, 2022 21:34
jglick added a commit to jglick/jenkins-infra-test-plugin that referenced this pull request Jun 10, 2022
jglick added a commit to jenkinsci/jenkins-infra-test-plugin that referenced this pull request Jun 10, 2022
Base automatically changed from setup to main June 13, 2022 19:43
@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

@jetersen squash-merged #1, making this more complicated…

@jetersen
Copy link
Collaborator

jetersen commented Jun 13, 2022

git pull --rebase origin main makes it super easy 🤔

@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

I used some git-rebase variant but it was complicated by the base branch going away.

@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

jenkinsci/jenkins-infra-test-plugin#23 was correctly ignored; now checking that jenkinsci/jenkins-infra-test-plugin#24 correctly triggers a release.

@jetersen
Copy link
Collaborator

https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/6869048725?check_suite_focus=true seems to work @jglick

@jetersen
Copy link
Collaborator

Fixed the build failure by using a version bom that had 2.249.x bom:

jenkinsci/jenkins-infra-test-plugin@49b5815 my bad for not making a PR 😐 Though this commit still triggered a release so win/win? 😅
https://github.com/jenkinsci/jenkins-infra-test-plugin/releases/tag/69.v49b_5815e8158

jglick referenced this pull request in jenkinsci/jenkins-infra-test-plugin Jun 13, 2022
@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

https://github.com/jenkinsci/bom/releases?page=3 huh, I seem to have picked a version from my local repo that was in incrementals but not releases. At least this demonstrated that jenkins-infra/jenkins-maven-cd-action#3 is fixed!

@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

this commit still triggered a release

Yes, any commit could trigger a release if the currently unreleased changes include at least one PR with an interesting label.

@jetersen
Copy link
Collaborator

jetersen commented Jun 13, 2022

@jglick you should be able to use the github's release page on https://github.com/jenkins-infra/interesting-category-action/releases to draft a new release and pick a tag like v1.2.0 ? 👏
EDIT: whelp just as fast I as I could type it, you created a release 😆

@jglick jglick marked this pull request as ready for review June 13, 2022 20:56
@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

use the github's release page

Actually easier:

gh release create v1.2.0 --generate-notes

@jetersen
Copy link
Collaborator

jetersen commented Jun 13, 2022

@jglick cool! Did not know that CLI options existed!

@jetersen jetersen merged commit bab1522 into main Jun 13, 2022
@jetersen jetersen deleted the race-condition-2 branch June 13, 2022 21:09
@jglick
Copy link
Collaborator Author

jglick commented Jun 13, 2022

So what is the next step here? We need an initial release tag. Then I can update the test plugin to use that as a final sanity check. Then we should amend the workflow template in .github to suggest it, and start rolling it out to various plugins?

@jetersen
Copy link
Collaborator

Yea @jglick :)

I suggest we create a v1.0.0 and a v1

and than move v1 along v1.x.x and revert v1 if we have any bad v1.x.x releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants