Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: fix include bypass of EntryFilter#filter symlink check #7226

Merged
merged 2 commits into from Sep 7, 2018
Merged

Security: fix include bypass of EntryFilter#filter symlink check #7226

merged 2 commits into from Sep 7, 2018

Commits on Sep 7, 2018

  1. Add failing tests for symlink check.

    @parkr
    parkr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1421180 View commit details
    Browse the repository at this point in the history

  2. EntryFilter#filter: reject all symlinks, even if included 

    Previously, you could include the name of a symlinked file
and Jekyll would not filter it. This is considered a bypass
of the symlink checking, and thus a security bug.
    @parkr
    parkr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    d0dbd5a View commit details
    Browse the repository at this point in the history