Security: fix include bypass of EntryFilter#filter symlink check
#7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Sep 7, 2018
ashmaroli
changed the title
parkr
changed the title
include bypass of EntryFilter#filter symlink check
|
👍 once we appease Rubocop |
Previously, you could include the name of a symlinked file and Jekyll would not filter it. This is considered a bypass of the symlink checking, and thus a security bug.
parkr
force-pushed
the
entryfilter-symlink-fix
branch
from
3dec37d
to
d0dbd5a
Compare
|
@jekyllbot: merge +bug |
jekyllbot
added a commit
that referenced
this pull request
Sep 7, 2018
parkr
added a commit
that referenced
this pull request
Sep 7, 2018
parkr
added a commit
that referenced
this pull request
Sep 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
EntryFilter#filter, we check forinclude?before we check forsymlink?, which allows symlinks to be read in a build when they shouldn't be by just including them./cc #7224