Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diff syntax-highlighting #6388

Merged
merged 1 commit into from Sep 27, 2017
Merged

Conversation

ashmaroli
Copy link
Member

Since this is subjective, its going to take some inputs from multiple perspective..

Current:
image

PR Initial Commit:

diff-syntax

@ashmaroli
Copy link
Member Author

/cc @jekyll/documentation

@DirtyF
Copy link
Member

DirtyF commented Sep 27, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 7d36527 into jekyll:master Sep 27, 2017
jekyllbot added a commit that referenced this pull request Sep 27, 2017
@ashmaroli ashmaroli deleted the docs-diff-style branch September 27, 2017 09:21
@DirtyF
Copy link
Member

DirtyF commented Sep 27, 2017

We should have kept the bold here but it's already more readable, that's what matters the most. Thanks.

@ashmaroli
Copy link
Member Author

Bold + text-shadow seemed a li'l too much to me..

@ashmaroli
Copy link
Member Author

@DirtyF see the extra borders around the code blocks in the pics above..? I'm guessing it has something to do with the change in Rouge versions.. (GitHub Pages is still on the older version..)
Is that worth addressing..?

@DirtyF
Copy link
Member

DirtyF commented Sep 27, 2017

@ashmaroli
Copy link
Member Author

handled in #6389 ...

@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants