Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for theme-gem installation #6387

Merged
merged 1 commit into from Sep 27, 2017
Merged

Improve documentation for theme-gem installation #6387

merged 1 commit into from Sep 27, 2017

Conversation

ashmaroli
Copy link
Member

Ref: Question at Jekyll Talk and another at StackOverflow

/cc @jekyll/documentation

DirtyF
DirtyF reviewed Sep 27, 2017
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your change, but we better fix the current diff ugly highlight style.

diff-style-jekyll

Maybe we could avoir using diff for now?

@ashmaroli
Copy link
Member Author

ashmaroli commented Sep 27, 2017 •
edited

I've already prepared that locally.. will start another PR once this is merged..
started #6388 for discussions before this gets merged..

@DirtyF
Copy link
Member

DirtyF commented Sep 27, 2017

@jekyllbot: merge +docs

Thanks @ashmaroli

@jekyllbot jekyllbot merged commit eadad9e into jekyll:master Sep 27, 2017
jekyllbot added a commit that referenced this pull request Sep 27, 2017
@jekyllbot
Update history to reflect merge of #6387 [ci skip]
528c03c
@ashmaroli ashmaroli deleted the theme-docs branch September 27, 2017 09:19
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@parkr parkr Awaiting requested review from parkr

Assignees

@DirtyF DirtyF

@parkr parkr

Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashmaroli @DirtyF @parkr @jekyllbot