Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jekyll-sass-converter 3.x #9132

Merged
merged 1 commit into from Oct 16, 2022
Merged

Support jekyll-sass-converter 3.x #9132

merged 1 commit into from Oct 16, 2022

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Sep 23, 2022

This is a 🙋 feature or enhancement.

Summary

jekyll-sass-converter 3.x release will come soon. This PR relaxes version requirements so that users will be able to choose between 2.x and 3.x.

On API level there is no change, thus it remains compatible with current jekyll.

However, there are a few behavior changes espeically in regard to how sass import works that may break a small fraction of users if they didn't lock dependency version: https://github.com/jekyll/jekyll-sass-converter#migrate-from-2x-to-3x

Context

jekyll/jekyll-sass-converter#140

@ashmaroli
Copy link
Member

Thanks @ntkme
@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 03f7ddc into jekyll:master Oct 16, 2022
jekyllbot added a commit that referenced this pull request Oct 16, 2022
github-actions bot pushed a commit that referenced this pull request Oct 16, 2022
なつき: Support jekyll-sass-converter 3.x (#9132)

Merge pull request 9132
@ntkme ntkme deleted the jekyll-sass-converter-3.x branch October 16, 2022 18:29
lylo pushed a commit to lylo/jekyll that referenced this pull request Oct 27, 2022
lylo pushed a commit to lylo/jekyll that referenced this pull request Oct 27, 2022
lylo pushed a commit to lylo/jekyll that referenced this pull request Oct 27, 2022
* master: (27 commits)
  Remove noise in `features/highlighting.feature`
  Release 💎 v4.3.1
  Update history to reflect merge of jekyll#9171 [ci skip]
  Release post for v4.3.1 (jekyll#9171)
  Update history to reflect merge of jekyll#9170 [ci skip]
  Revert "Incrementally rebuild when a data file is changed (jekyll#8771)" (jekyll#9170)
  Update history to reflect merge of jekyll#9167 [ci skip]
  Respect user-defined name attribute in documents (jekyll#9167)
  Revert back to developing 4.3.x
  Mark initiation of v5.0 development
  Disable critical GH Actions on `master`
  Fix spelling errors in History document
  Release 💎 v4.3.0
  Update history to reflect merge of jekyll#9157 [ci skip]
  Release post for v4.3.0 (jekyll#9157)
  Clean up HEAD section in History document
  Document xz dependency on macOS (jekyll#9098)
  Fix URL to Liquid documentation (jekyll#9158)
  Bump RuboCop to `v1.37.x`
  Update history to reflect merge of jekyll#9132 [ci skip]
  ...
@jekyll jekyll locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants