Time for a new release

[jekyllbot]

Hello, maintainers! 👋

By my calculations, it's time for a new release of jekyll-sass-converter. It's been over 2 months since the last release, v2.2.0.

What else is left to be done before a new release can be made? Please make sure to update History.markdown too if it's not already updated.

Thanks! 💞 ✨

[ntkme]

@ashmaroli I withdrawed #142 as it does not provide much real value, anything else we want to do before cutting 3.x?

By the way, I opened jekyll/jekyll#9132 to relax the version requirement of this gem in Jekyll.

[ashmaroli]

Okay @ntkme. Changes to this plugin's codebase aside, I would like to first see how tests at Jekyll Core repository responds to having sass-embedded as the default implementation.

Local use with Jekyll's out-of-the-box theme "Minima" threw numerous deprecation warnings into the stderr channel. I couldn't see any way to "temporarily silence" those warnings so I feel users will start complaining about the unexpected change in their log output when this is shipped as is.

Currently, the builds with Minima doesn't break. But I would like to gather feedback from popular third-party theme authors (via the Jekyll Talk platform) if their themes continue to work. So, let us "not rush" into cutting a 3.0.0.

[ntkme]

Fair enough for me.

[jekyllbot]

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

[ntkme]

@ashmaroli What about cutting 3.0.0.pre.alpha1? It allows installing without using git, and at the same time because it is a prerelease, 2.x would still be the default for users.

[ashmaroli]

Cutting a pre-release version sounds like a good idea, @ntkme.

[ntkme]

@ashmaroli Would you mind cut the pre-release when available?

One issue I observed by checking how users are actually using sass-embedded via https://github.com/ntkme/sass-embedded-host-ruby/network/dependents is that some of early adopters actually have incorrect configuration in their Jekyll site, partially due to that our README is for 3.x but 3.x is not available yet other than directly installing from git, for which many users are not aware of.

[ashmaroli]

@ntkme I see some errors while running tests locally. I see similar errors in our CI logs, but those errors never returned a non-zero exit code.
Could you check?

[ntkme]

@ashmaroli Tests are all passing for me, and so did the CI https://github.com/jekyll/jekyll-sass-converter/actions/runs/3645990199

Are you talking about the message like below?

Error: expected ";".
  ╷
2 │ body {
  │      ^
  ╵
  - 2:6  root stylesheet 

That is a log from here:

jekyll-sass-converter/lib/jekyll/converters/scss.rb

Lines 173 to 176 in 3b0d920

	rescue ::Sass::CompileError => e
	Jekyll.logger.error e.full_message
	raise SyntaxError, e.message
	end

Which is coming from this test:

jekyll-sass-converter/spec/scss_converter_spec.rb

Lines 128 to 133 in 3b0d920

	it "includes the syntax error line in the syntax error message" do
	expected = %r!expected ";"!i
	expect { scss_converter.convert(invalid_content) }.to(
	raise_error(Jekyll::Converters::Scss::SyntaxError, expected)
	)
	end

In the test, the raised error is caught, so that it just simply continues. When you’re building a real site, such error will indeed cause the build to quit with an error code.

[ashmaroli]

Yes, I was referring to those tests indeed, @ntkme.
I will ship the prerelease on 21/12/22.
Thanks for all the contributions you have made so far. 🙂

[ashmaroli]

I decided to ship the prime release directly.
v3.0.0 has been shiipped.