Upgrade Jekyll to drop sassc dependency #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Newer versions of Jekyll support jekyll-sass-converter 3.x, which doesn't have an official gem release yet, but will drop sassc as the default Sass compiler. The sassc dependency causes long build times due to its native build requirements during installation in Cloud.gov Pages build environments. As of #1000, we no longer rely on Jekyll for any Sass compilation, so ideally we'd not be installing any Ruby Sass dependencies, but this is the next best option.
|
Based on failing Cloud.gov Pages build, we may need to upgrade Ruby version. |
This was referenced Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Newer versions of Jekyll support jekyll-sass-converter 3.x, which doesn't have an official gem release yet, but will drop sassc as the default Sass compiler. The sassc dependency causes long build times due to its native build requirements during installation in Cloud.gov Pages build environments. The hope with these changes is to reduce build times.
As of #1000, we no longer rely on Jekyll for any Sass compilation, so ideally we'd not be installing any Ruby Sass dependencies, but this is the next best option.
Release notes: https://github.com/jekyll/jekyll/releases