Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @types and packages that break @types #1711

Closed

Conversation

benschac
Copy link
Contributor

What does this PR do and why?

Updates types for React 18 this diff fixes all type errors from types.

Note: I think it makes sense to merge this diff into #1647 so cli will pass.

WARNING ANTD modals are broken, issue is addressed in the next diff

In order to do so, there were a couple of steps that needed to be taken:

Screenshots or screen recordings

If applicable, provide screenshots or screen recordings to demonstrate the changes.

Acceptance checklist

Screenshots or screen recordings

If applicable, provide screenshots or screen recordings to demonstrate the changes.

Acceptance checklist

@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
juice-interface-rinkeby ❌ Failed (Inspect) Aug 10, 2022 at 5:21PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
juice-interface ⬜️ Ignored (Inspect) Aug 10, 2022 at 5:21PM (UTC)

@benschac
Copy link
Contributor Author

benschac commented Aug 10, 2022

@benschac
Copy link
Contributor Author

closing stack, for more context: #1712

@benschac benschac closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant