Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom document to next app #1665

Closed

Conversation

benschac
Copy link
Contributor

@benschac benschac commented Aug 3, 2022

What does this PR do and why?

Note: This can go in without the rest of the react 18 upgrade stack.

was getting this warning https://nextjs.org/docs/messages/no-stylesheets-in-head-component

moved script tags to custom document so Streaming and Suspense don't break the app with react 18.

Acceptance checklist

@vercel
Copy link

vercel bot commented Aug 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
juice-interface-rinkeby ❌ Failed (Inspect) Aug 10, 2022 at 5:21PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
juice-interface ⬜️ Ignored (Inspect) Aug 10, 2022 at 5:21PM (UTC)

This was referenced Aug 3, 2022
@benschac
Copy link
Contributor Author

benschac commented Aug 3, 2022

@benschac
Copy link
Contributor Author

benschac commented Aug 4, 2022

It makes sense that this isn't working on rink. When merging the stack it should run ci against main before squash and merge and deploy ✅

I can also pull it off this stack and make it it's own stack too, if that's easier.

@tomquirk
Copy link
Contributor

tomquirk commented Aug 8, 2022

@wraeth-eth could you review this one?

@benschac
Copy link
Contributor Author

this can go in on its own, can also close it. Lmk @wraeth-eth

@benschac benschac closed this Aug 12, 2022
@wraeth-eth
Copy link
Contributor

Sorry, been out for the past few days - just saw this one is now closed. Did we want to re-open or was it closed for a reason @benschac ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants