Add --all-extras flag to pip-compile
#1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apljungquist
force-pushed
the
master
branch
4 times, most recently
from
acd7e78
to
cb5216f
Compare
atugushev
reviewed
Jun 28, 2022
The goal is to make it easy to compile version locks for all runtime dependencies in a way that is robust to human error. By using the wildcard extra the risk of forgetting to list any extra is removed. Since the expanded extras are needed when we look for the wildcard it is moved to before the loop. This is OK because it does not depend on the loop and nothing in the loop depends on its previous value.
apljungquist
force-pushed
the
master
branch
from
a0cff0f
to
76ac553
Compare
atugushev
reviewed
Sep 30, 2022
... to not give users the misleading impression that pattern matching, with regex, fnmatch or some other system, works.
atugushev
approved these changes
Oct 1, 2022
There was a problem hiding this comment.
LGTM 👍🏻
@apljungquist could you please update the PR title?
apljungquist
changed the title
--extra--all-extras flag to pip-compile
|
Certainly. Thanks for being patient and guiding me through the process. |
webknjaz
reviewed
Oct 2, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
ssbarnea
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make it easy to compile version locks for all runtime
dependencies in a way that is robust to human error. By using the
wildcard extra the risk of forgetting to list any extra is removed.
Is this a use case pip-tools wants to support?
If yes, is the current approach a good one?
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.