Update PyPIRepository::resolve_reqs() for pip>=22.1.1
#1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw the discussion in #1623. If I get the gist of it right, since pip internals are used by pip-tools, we have to either add conditionals like the one here, or we need to vendor pip. So until a decision is made on vendoring, this should be an ok solution. |
RazerM
approved these changes
May 23, 2022
|
Only Ubuntu 3.11-dev is failing and it doesn't seem related |
ssbarnea
approved these changes
May 23, 2022
|
I'll merge and prepare the release shortly. |
|
@atugushev That was my plan. Merge whatever is ready and safe to merge and tag a new release to fix the serious bug with newer pip. |
atugushev
changed the title
PyPIRepository::resolve_reqs() for pip>=22.1.1
apatard
added a commit
to apatard/schemas
that referenced
this pull request
May 23, 2022
Currently, things are failing due to pip-tools not working with pip >= 22.1.1. So avoid these versions until jazzband/pip-tools#1624 is merged and found in released version. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea
added a commit
to ansible/schemas
that referenced
this pull request
May 24, 2022
* tox.ini: Set skipsdist On my debian bullseye system, tox is complaining: ERROR: No pyproject.toml or setup.py file found. The expected locations are: ... Set skipsdist to True to avoid that. Signed-off-by: Arnaud Patard <apatard@hupstream.com> * tox.ini: Avoid pip >= 22.1.1 Currently, things are failing due to pip-tools not working with pip >= 22.1.1. So avoid these versions until jazzband/pip-tools#1624 is merged and found in released version. Signed-off-by: Arnaud Patard <apatard@hupstream.com> * negative_test/roles/meta_invalid_role_namespace/meta/main.yml.md: update Update file with version generated out of tox run. Signed-off-by: Arnaud Patard <apatard@hupstream.com> * Update tox.ini Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
|
Thanks for the quick release! |
MichaelRoytman
added a commit
to openedx/xblock-lti-consumer
that referenced
this pull request
Jun 8, 2022
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
MichaelRoytman
added a commit
to edx/portal-designer
that referenced
this pull request
Jun 8, 2022
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
MichaelRoytman
added a commit
to openedx/edx-ora2
that referenced
this pull request
Jun 8, 2022
This commit upgrades the version of pip-tools used in this repository from 6.6.1 to 6.6.2. In version 6.6.1 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "AttributeError: 'RequirementSet' object has no attribute 'add_requirement'". The error was reported here: jazzband/pip-tools#1623. The fix to this bug was released in version 6.6.2 of pip-tools. See the pull request here: jazzband/pip-tools#1624.
MichaelRoytman
added a commit
to openedx/super-csv
that referenced
this pull request
Jun 8, 2022
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
This was referenced Jun 8, 2022
Merged
MichaelRoytman
added a commit
to openedx/edx-bulk-grades
that referenced
this pull request
Jun 9, 2022
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
9 tasks
MichaelRoytman
added a commit
to edx/edx-name-affirmation
that referenced
this pull request
Aug 2, 2022
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
5 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip 22.1.1 splits RequirementSet::add_requirement() to RequirementSet::add_named_requirement() and RequirementSet::add_unnamed_requirement(). Here, we update PyPIRepository::resolve_reqs() to call the right method.
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.Fixes #1623