fix: upgrade pip-tools to fix bug in version 6.6.1 #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the version of pip-tools used in this repository from 6.6.1 to 6.6.2. In version 6.6.1 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "AttributeError: 'RequirementSet' object has no attribute 'add_requirement'". The error was reported here: jazzband/pip-tools#1623. The fix to this bug was released in version 6.6.2 of pip-tools. See the pull request here: jazzband/pip-tools#1624.
Codecov Report
@@ Coverage Diff @@
## master #1862 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 153 153
Lines 17014 17014
Branches 1875 1875
=======================================
Hits 16155 16155
Misses 643 643
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ashultz0
approved these changes
Jun 8, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR -
This commit upgrades the version of pip-tools used in this repository from
6.6.0to6.6.2.In version
6.6.0ofpip-tools, there is a bug that is preventingpip-toolsfrom working. This is breaking the Python requirements update GitHub action in this repository.The error is
ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'. The error was reported here. The fix to this bug was released in version6.6.2ofpip-tools. See the comment here.Version
6.6.1ofpip-toolsalso has a bug, which is fixed in version6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to6.6.2. The issue in version6.6.1was reported here.JIRA: None.
What changed?
See above.
Developer Checklist
Testing Instructions
make upgrade.Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora