Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pip>=22.1 #1607

Merged
merged 11 commits into from Apr 4, 2022
Merged

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Mar 31, 2022

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the enhancement Improvements to functionality label Mar 31, 2022
@atugushev atugushev added this to the 6.6.0 milestone Mar 31, 2022
Copy link
Contributor

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah! Thanks for picking this up. I have a very minor suggestion.

tox.ini Outdated Show resolved Hide resolved
@atugushev atugushev marked this pull request as ready for review April 4, 2022 09:03
@atugushev atugushev requested a review from a team April 4, 2022 09:08
@ssbarnea ssbarnea requested a review from pradyunsg April 4, 2022 11:19
@ssbarnea
Copy link
Member

ssbarnea commented Apr 4, 2022

I requests @pradyunsg to update its review so I will wait for his comment or approval before merging. That is a very welcomed addition.

@pradyunsg pradyunsg removed their request for review April 4, 2022 12:07
@pradyunsg
Copy link
Contributor

Please feel free to merge this without waiting on my review. If I have time to do a review, I’ll do one. :)

@atugushev
Copy link
Member Author

Thanks @duoi and @ssbarnea for the review! I'm gonna merge this then.

@atugushev atugushev merged commit ef8b856 into jazzband:master Apr 4, 2022
@atugushev atugushev deleted the pip-22.1-support branch April 4, 2022 14:53
@atugushev atugushev changed the title Add support for pip==22.1 Add support for pip>=22.1 Apr 4, 2022
@wizpig64 wizpig64 mentioned this pull request May 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants