Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for pip>=22.1 #1618

Merged
merged 1 commit into from May 13, 2022
Merged

Conversation

wizpig64
Copy link
Contributor

@wizpig64 wizpig64 commented May 12, 2022

Since #1607, which originally added 22.1 support, pip changed under the hood before release.

This PR fixes #1617, by moving an import inside the one function that needed it, which only ran under pip<22 anyway.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@wizpig64
Copy link
Contributor Author

wizpig64 commented May 12, 2022

The one failure aside from coverage is for python 3.11-dev. 3.11.0b1 was released recently, so someone ought to see if this is fixable too.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@atugushev atugushev merged commit ce441d2 into jazzband:master May 13, 2022
@atugushev atugushev added the bug Something is not working label May 13, 2022
@atugushev atugushev added this to the 6.6.1 milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error importing BAR_TYPES with new pip 22.1 release
3 participants