Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid spurious output during tests #1253

Merged
merged 1 commit into from Dec 4, 2020
Merged

Avoid spurious output during tests #1253

merged 1 commit into from Dec 4, 2020

Commits on Dec 3, 2020

  1. Avoid spurious output during tests 

    It is often convenient to use the pytest option "-s" (shortcut for
--capture=no) to view one's own debugging print() output. When there is
already lots of spurious output, it produces lots of noise and it may be
difficult to view the intended debugging output. By avoiding unnecessary
output, it is easier to find.

Tests that have intentional output now assert that output. For example,
the output of the sync command is now asserted. In addition to the
advantage above, this creates a more robust test suite as the expected
behavior is now more explicit, precise, and better covered.
    @jdufresne
    jdufresne committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    7cd9d58 View commit details
    Browse the repository at this point in the history