Avoid spurious output during tests #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
=======================================
Coverage 99.58% 99.59%
=======================================
Files 36 36
Lines 2923 2947 +24
Branches 332 333 +1
=======================================
+ Hits 2911 2935 +24
Misses 6 6
Partials 6 6
Continue to review full report at Codecov.
|
atugushev
reviewed
Dec 3, 2020
atugushev
reviewed
Dec 3, 2020
atugushev
reviewed
Dec 3, 2020
It is often convenient to use the pytest option "-s" (shortcut for --capture=no) to view one's own debugging print() output. When there is already lots of spurious output, it produces lots of noise and it may be difficult to view the intended debugging output. By avoiding unnecessary output, it is easier to find. Tests that have intentional output now assert that output. For example, the output of the sync command is now asserted. In addition to the advantage above, this creates a more robust test suite as the expected behavior is now more explicit, precise, and better covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is often convenient to use the pytest option "-s" (shortcut for
--capture=no) to view one's own debugging print() output. When there is
already lots of spurious output, it produces lots of noise and it may be
difficult to view the intended debugging output. By avoiding unnecessary
output, it is easier to find.
Tests that have intentional output now assert that output. For example,
the output of the sync command is now asserted. In addition to the
advantage above, this creates a more robust test suite as the expected
behavior is now more explicit, precise, and better covered.
Changelog-friendly one-liner:
Contributor checklist