Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation test for JEP 433: Pattern Matching for switch #1191

Merged
merged 1 commit into from Feb 16, 2023

Conversation

Godin
Copy link
Member

@Godin Godin commented May 27, 2021

This requires OpenJDK 17 Early Access build with openjdk/jdk#3863

@Godin Godin added this to the 0.8.8 milestone May 27, 2021
@Godin Godin self-assigned this May 27, 2021
@Godin Godin added this to Implementation in Current work items via automation May 27, 2021
@marchof
Copy link
Member

marchof commented May 27, 2021

@Godin Before we add new validation test project for Java 17 what about my proposed validation test cleanups up to Java 16 in #1165? Maybe we merge this first?

@Godin
Copy link
Member Author

Godin commented May 27, 2021

@marchof

what about my proposed validation test cleanups up to Java 16 in #1165? Maybe we merge this first?

yup - I was about to look at it today 😉
and this one is still draft - we can't merge it before openjdk/jdk#3863 😉 for which I did this changes locally to play with it a bit, and created this draft just to not loose/forget

@Godin Godin force-pushed the java17_jep406_switch_pattern_matching branch from 7a8f2e5 to 22c64fa Compare May 28, 2021 00:57
@Godin Godin force-pushed the java17_jep406_switch_pattern_matching branch from 73b029e to 7e02f5f Compare June 14, 2021 10:23
@mirabilos
Copy link

Can you please move this to 0.8.9 and release 0.8.8 in the meantime? I don’t use JDK 17, only JDK 8/11 with JRE 8, but I do need the assert filtering… Thanks in advance!

@Godin Godin force-pushed the java17_jep406_switch_pattern_matching branch from 7e02f5f to e4e004a Compare June 29, 2021 15:21
@Godin Godin modified the milestones: 0.8.8, 0.8.9 Apr 4, 2022
@Godin Godin force-pushed the java17_jep406_switch_pattern_matching branch from e4e004a to b4ab2d2 Compare February 15, 2023 14:15
@Godin Godin changed the title Add validation test for JEP 406: Pattern Matching for switch Add validation test for JEP 433: Pattern Matching for switch Feb 15, 2023
@Godin Godin force-pushed the java17_jep406_switch_pattern_matching branch from b4ab2d2 to 2ed585e Compare February 15, 2023 14:19
@Godin
Copy link
Member Author

Godin commented Feb 15, 2023

@marchof I updated this PR to the most recent https://openjdk.org/jeps/433

@Godin Godin marked this pull request as ready for review February 15, 2023 14:59
@Godin Godin requested a review from marchof February 15, 2023 14:59
@Godin Godin moved this from Implementation to Review in Current work items Feb 15, 2023
@marchof
Copy link
Member

marchof commented Feb 15, 2023

Hi @Godin, I wonder whether we still want to provide Eclipse .project and .classpath files like for the other projects (disclaimer: JavaSE-20 is not yet supported by latest Eclipse).

@Godin
Copy link
Member Author

Godin commented Feb 16, 2023

I wonder whether we still want to provide Eclipse .project and .classpath files like for the other projects

Oops, I have them locally, but forgot to commit, because I use IntelliJ IDEA and my global .gitignore excludes everything starting with the dot 🤦

JavaSE-20 is not yet supported by latest Eclipse

I don't think that this should stop us from the addition of tests so that they can be executed at least in CI.
Thus IMO there are two options - I can create a ticket to not forget to add these files later when Eclipse will add support for JavaSE-20, or include them in this PR. Which option do you prefer?

@marchof
Copy link
Member

marchof commented Feb 16, 2023

I would add execution environment JavaSE-20 right now. It will be supported in 4 week with the upcoming Eclipse release.

@Godin Godin force-pushed the java17_jep406_switch_pattern_matching branch from 2ed585e to 568edf9 Compare February 16, 2023 08:48
@Godin
Copy link
Member Author

Godin commented Feb 16, 2023

@marchof done!

@marchof marchof merged commit 9067006 into master Feb 16, 2023
Current work items automation moved this from Review to Done Feb 16, 2023
@marchof marchof deleted the java17_jep406_switch_pattern_matching branch February 16, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants