New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module for Java 16 validation tests #1165
Conversation
717780e
to
81f76bc
Compare
81f76bc
to
dddc0ee
Compare
@marchof currently
ie both as a preview feature in 14 and 15 and as a standard feature in 16+
? I guess this is because strategy in IDEs is to support preview features of latest release and stop supporting preview features of previous releases? Like Eclipse probably already did, and IntelliJ started to warn. Right? |
...t.validation.java16/src/org/jacoco/core/test/validation/java16/targets/InstanceofTarget.java
Show resolved
Hide resolved
...test.validation.java16/src/org/jacoco/core/test/validation/java16/targets/RecordsTarget.java
Outdated
Show resolved
Hide resolved
@Godin Correct, the idea is to only test released features in the long run. To keep our test set maintainable we only test not-yet-released preview features primarily to prepare ourself and provide feedback to OpenJDK. I thought we discussed this once. |
oh, I see - https://groups.google.com/g/jacoco-dev/c/edIrAG85jho/m/k4c8_ZzIDwAJ
but not
😆 |
@Godin I don't insist on this. We can also keep testing preview features. But given the fact the the respective Java versions are already EOL and we had version specific switches in our validation code from my point of view we can drop those preview tests. |
3a9b550
to
6b541e0
Compare
Also remove preview features from Java 14 validation tests.
6b541e0
to
69451f3
Compare
Rebased and Maven versions fixed to get a green build. |
@marchof Also this PR reminded me about absence of validation test with Sealed Classes - if it was present, we would not have missed #1097 (comment) and would have detected the problem automatically earlier 😉 Sealed Classes are preview feature in 15 and 16 and will be finalized in 17 - https://openjdk.java.net/jeps/409 And since for them there is a special handling in https://openjdk.java.net/jeps/406 will be indeed simpler to add them in/after/together with #1191 than alone in And indeed seems that in IntelliJ IDEA 2021.1 ability to use Java 14 with preview features already not available: And seems that in upcoming Eclipse 2021-06 ability to use preview features available only for Java 16: |
Also remove preview features from Java 14 validation tests.