Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Add
params_show
#3459api: Add
params_show
#3459Changes from 11 commits
83fd85d
59e38bc
044cade
6d16c25
9bbbe25
3d33521
1f7ca1f
cc11224
6490cc9
c3b5e3b
6b33374
a631f32
e19dda0
c2d9ec8
c72d752
cb77cb4
92da7c5
23d7099
090feaa
6e3b8a7
834e47b
3060eef
7529503
9572e72
5032c5a
3ced721
1af16ab
2e02967
2a70b7d
590dfdc
4f755c0
1c53cc6
b8cbaf1
712464d
2525cf9
24f18aa
87ebba4
e8596d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be moved above
repo
?stages
seems more important, and it makes sense to me to put it right aftertargets
and keeprepo
andrev
together.This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the signature from what I can tell. I don't think we should alter it for docs (other than that one comment I added).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said if you plan to change the signature in the core repo then sure. Lmk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that those are all keyword arguments so the order doesn't really affect the behavior. We could also update the order in core, if it makes more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind updating in core, but to me it's more important to update here to start with more common use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I moved
stages
one position up. Why not all the way up then? Since we deem the stage-filtering example most important... Which goes back to iterative/dvc#7613 (review)I think that's ideal because at some point this may get copy-pasted again from there (on some update) and our custom docs order is gone.