Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Add params_show #3459

Merged
merged 38 commits into from Jul 4, 2022
Merged

api: Add params_show #3459

merged 38 commits into from Jul 4, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Apr 22, 2022 •
edited

@daavoo daavoo added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Apr 22, 2022
@daavoo daavoo requested review from dberenbaum and a team April 22, 2022 09:02
@daavoo daavoo self-assigned this Apr 22, 2022
@daavoo daavoo mentioned this pull request Apr 22, 2022
Merged
@daavoo daavoo marked this pull request as draft May 10, 2022 10:13
@julieg18 julieg18 temporarily deployed to dvc-org-api-get-params-2lnv5kl June 2, 2022 12:38 Inactive
@restyled-io restyled-io bot mentioned this pull request Jun 16, 2022
Closed
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl June 16, 2022 09:17 Inactive
@daavoo daavoo changed the title api: Add get_params api: Add params_show Jun 16, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl June 16, 2022 09:19 Inactive
@daavoo daavoo marked this pull request as ready for review June 16, 2022 09:22
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl June 16, 2022 10:45 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl June 16, 2022 10:48 Inactive
@jorgeorpinel

This comment was marked as resolved.

Sign in to view
@daavoo

This comment was marked as resolved.

Sign in to view
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl June 25, 2022 02:38 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl June 29, 2022 20:42 Inactive
@jorgeorpinel @daavoo
Apply suggestions from code review
1c53cc6 
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl June 29, 2022 20:48 Inactive
jorgeorpinel
jorgeorpinel approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. @daavoo please address @dberenbaum's suggestions on the examples when you can 🙏🏼

@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl July 4, 2022 09:35 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl July 4, 2022 09:36 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl July 4, 2022 09:42 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl July 4, 2022 10:02 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl July 4, 2022 10:03 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-api-get-params-2lnv5kl July 4, 2022 10:04 Inactive
@daavoo daavoo merged commit a43701b into main Jul 4, 2022
@daavoo daavoo deleted the api-get-params branch July 4, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum left review comments

@shcheklein shcheklein shcheklein left review comments

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees

@jorgeorpinel jorgeorpinel

@daavoo daavoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@daavoo @jorgeorpinel @dberenbaum @shcheklein @julieg18