New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add completion support for namespace #33787
add completion support for namespace #33787
Conversation
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, But my only concern is the cobra version upgrade. Not sure if it will break something which is not in the test.
I will let others provide their feedback.
add release note upgrade cobra to 1.2.1 for parallel use of the cmd.RegisterFlagCompletionFunc()
e711ffc
to
ff42ee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get this working locally using zsh, but maybe just my environment.. LGTM
I did get this working locally (Mac using zsh) by doing a |
Add namespace completion supports for
istioctl
.[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
This PR needs cobra 1.2.0 for the PR RegisterFlagCompletionFunc as a global var not working in multi-threaded programs, to fix
concurrent map writes errors
of tests in parallel of istio(here is an example, this is introduced by #28434).And as cobra 1.2.0 add a new feature Automatically adds completion command for shell completions, this PR will also add a new command
istioctl completion
. I will replaceistioctl collateral --bash/--zsh
toistioctl completion bash/zsh
in another PR later.Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.