Remove istioctl collateral bash/zsh

[ericvn]

Describe the feature request

The way to create the completion files has changes to istioctl completion zsh/bash per an earlier PR (#33787). I have created a PR to use the new commands as part of the make (#34091). We should deprecate/remove the collateral zsh/bash from istioctl.

Describe alternatives you've considered

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

Additional context

[esnible]

Can this be closed?

[ericvn]

No. Running ./out/darwin_amd64/istioctl collateral completion --zsh still generates a file which is different than ./out/darwin_amd64/istioctl completion zsh > _istioctl_2 and the later should be correct per #33787.

completion is shown as the available command. I suspect we just want to remove/deprecate as it is now wrong collateral --bash and collateral --zsh or point them to the correct new command.

[istio-policy-bot]

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-08-13. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.