Remove dependency on deprecated module "os-homedir" #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2018 17:00
…of node, since os-homedir is deprecated
|
This appveyor instance seems to install the latest npm, instead of the latest compatible npm as reported here - shelljs/shelljs#844 |
|
Could you send this PR against the |
|
@EightArmCode thanks for the contribution. Removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os-homedir was deprecated in favor of using the global module. This PR removes that dependency and tries to shim another option using
process.env.HOMEfor older versionsPlease republish to npm when it is working correctly