Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on deprecated module 'os-homedir' #1

Closed
wants to merge 1 commit into from
Closed

Remove dependency on deprecated module 'os-homedir' #1

wants to merge 1 commit into from

Conversation

EightArmCode
Copy link

No description provided.

@demurgos
Copy link
Owner

Hi,
As mentioned in my other message, the goal would be to remove it from the next branch (not master).

I think the only change should be around this line:

return path.join(osHomedir(), DEFAULT_SHIM_ROOT_NAME);

(and remove imports/dependency)

@EightArmCode
Copy link
Author

I see. When do you anticipate this update will be publishable to NPM?

@demurgos
Copy link
Owner

demurgos commented Aug 29, 2018

The next branch is temporarily published as demurgos-spawn-wrap (it is used as part of the c8 update).
The c8 update is the main blocker to merge the various forks. There is still a bit of work around the Node API, coverage branches and CLI handling. I'll try to work on this during the week-end. It will definitely be finished by the end of September (hopefully sooner). This fork will then be merged and published on npm as spawn-wrap (the goal is not to have a long-lived fork).

@EightArmCode
Copy link
Author

alright sounds cool. I'll try to get to it today.

@EightArmCode
Copy link
Author

So sorry I got busy and then have been gone on holiday. Going to create a PR on the next branch now...

@EightArmCode
Copy link
Author

Alright - I've deleted my fork and re-forked/cloned and it appears that you've already merged my changes. Am I getting that right? The file you mentioned above doesn't seem to exist anymore, and I see my own "git blame" entry in the current version. Do you still need me to do anything with this?

@demurgos
Copy link
Owner

I don't believe I merged it (the next branch still uses os-homedir).

I prefer to keep the PR open at the moment. I opened many PRs to spawn-wrap and other libraries used for code coverage, but the maintainers seem to be busy.

@demurgos
Copy link
Owner

The PRs are starting to get merged to spawn-wrap. I'll make sure that this change is included.

@demurgos
Copy link
Owner

Fixed in the main spawn-wrap lib.

@demurgos demurgos closed this May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants